Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed _select call when there is no onSelectionChange #168

Merged
merged 1 commit into from
Nov 30, 2017
Merged

fixed _select call when there is no onSelectionChange #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions addon/components/frost-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,22 +317,22 @@ export default Component.extend({
},

_select ({isRangeSelect, isSpecificSelect, item}) {
const items = this.get('items')
const itemKey = this.get('itemKey')
const _itemComparator = this.get('_itemComparator')
const clonedSelectedItems = A(this.get('selectedItems').slice())
const _rangeState = this.get('_rangeState')

// Selects are proccessed in order of precedence: specific, range, basic
if (isSpecificSelect) {
selection.specific(clonedSelectedItems, item, _rangeState, _itemComparator)
} else if (isRangeSelect) {
selection.range(items, clonedSelectedItems, item, _rangeState, _itemComparator, itemKey)
} else {
selection.basic(clonedSelectedItems, item, _rangeState, _itemComparator)
}

if (this.onSelectionChange) {
const items = this.get('items')
const itemKey = this.get('itemKey')
const _itemComparator = this.get('_itemComparator')
const clonedSelectedItems = A(this.get('selectedItems').slice())
const _rangeState = this.get('_rangeState')

// Selects are proccessed in order of precedence: specific, range, basic
if (isSpecificSelect) {
selection.specific(clonedSelectedItems, item, _rangeState, _itemComparator)
} else if (isRangeSelect) {
selection.range(items, clonedSelectedItems, item, _rangeState, _itemComparator, itemKey)
} else {
selection.basic(clonedSelectedItems, item, _rangeState, _itemComparator)
}

this.onSelectionChange(clonedSelectedItems)
}
}
Expand Down