-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multi-select behavior #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frosetti Can you please provide a screen recording or a series of image captures elaborating on what your changelog description is describing? If I visit http://ciena-frost.github.io/ember-frost-list/#/ I can already select multiple items, can shift-click to do so, ctrl click, etc. I do not understand what the change in behavior is.
Can you also add a demonstration of this to the demo app so that others can see the behavior illustrated as well?
To give context, we need this feature because we have a very large list and accidentally missing the select box is a huge pain for our users. This feature has been requested by Katie Parmeson and other people on the UX team. |
I'm not trying to capriciously block this but I still do not understand the difference in the behavior introduced in this PR and would still like to see what new behavior these changes provide. |
The changelog might be more clear as something like...
|
Only interacting with checkboxes:
Only interacting with the rows (not the checkboxes):
What we should be doing is first synchronizing the behavior between what happens when interacting with the checkbox vs the rows - are they supposed to behave differently? Once that is squared away it may be that this PR isn't even needed. |
Have received an explanation of the change in behavior, though have a made a note that it is not how I believe we should approach this problem.
@notmessenger, Forrest convinced me there are valid use cases for both types of behavior, so an option makes sense. |
This project uses semver, please check the scope of this pr:
CHANGELOG