Vertical collection for paging #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quincyle
previously approved these changes
Jul 26, 2018
quincyle
reviewed
Jul 26, 2018
| @@ -73,6 +73,7 @@ export default Component.extend({ | |||
|
|
|||
| // Options - sub-components | |||
| pagination: PropTypes.EmberComponent, | |||
| useVerticalCollectionForPagination: PropTypes.bool, | |||
There was a problem hiding this comment.
Add this new attribute to API doc?
There was a problem hiding this comment.
I'll add that right now
quincyle
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Summary
Add flag to use
vertical collectionin the case of paging. This is useful when your page sizes are massive (like 200). Greatly improves the performance in these casesSemver
This project uses semver, please check the scope of this PR:
CHANGELOG
useVerticalCollectionForPaginationthat allows a consumer to usevertical-collectionduring pagination