Remove weird artifact #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the black border part of the table? If so I believe the intention of the gutter was to place the scrollbar outside (to the right) of the border - also can you confirm cross-browser on this (sorry, have to ask) |
|
The black border is just in the screenshots for some reason while it doesn't actually exist on the page. I'll perform the browser testing and make any updates required (if any are required). |
|
Verified it works in Chrome on OS X and IE 11 on Windows 7. Firefox isn't rendering the scrollbar on the proper container but that issue already exists prior to my change. Going to go ahead and add a new issue for that and get this PR green to merge. |
|
great timing on this fix 😃 |
|
👍 |
|
Thanks @sandersky! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PATCH
resolves #23
Before:
After:
