Update list on new spec #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,18 +12,30 @@ export default Ember.Component.extend({ | |||
| isSelected: Ember.computed.reads('model.isSelected'), | |||
|
|
|||
| onclick: Ember.on('click', function (event) { | |||
| if (!Ember.ViewUtils.isSimpleClick(event)) { | |||
| if (!Ember.ViewUtils.isSimpleClick(event) && !event.shiftKey && !event.metaKey && !event.ctrlKey) { | |||
There was a problem hiding this comment.
This should already be covered by isSimpleClick
There was a problem hiding this comment.
I'm trying to keep the function running when shiftKey or CtrlKey is pressed even it's not a SimpleClick.
|
Unless the functionality is required immediately, I'd like to spend an hour cleaning this code up before accepting the PR |
|
Approved with discussed changes |
|
👍 |
|
sorry misclicked 'close and comment' :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a #minor# change
Change behavior for row clicking selection
Feature for shiftKey down selection
Feature for ctrlKey down selection