Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add factory-guy mocking layer and remove mirage #59

Merged
merged 7 commits into from
Oct 18, 2016

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented Oct 18, 2016

PATCH

CHANGELOG

  • Added factory-guy mocking layer with factories
  • Updated tests to use factory-guy instead of mirage
  • Removed mirage mocking layer

This change is Reviewable

@sglanzer-deprecated
Copy link
Contributor

sglanzer-deprecated commented Oct 18, 2016

Approved

Approved with PullApprove

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling cd593a4 on juwara0:factoryGuy into * on ciena-frost:master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling cd593a4 on juwara0:factoryGuy into * on ciena-frost:master*.

@juwara0 juwara0 merged commit b9af821 into ciena-frost:master Oct 18, 2016
@TheOtherDude
Copy link
Contributor

@juwara0
Copy link
Contributor Author

juwara0 commented Oct 18, 2016

@TheOtherDude - Thanks for reporting. I am aware that this is broken and am trying to get it back up.

@juwara0
Copy link
Contributor Author

juwara0 commented Oct 18, 2016

@TheOtherDude I went ahead and opened an issue to track the broken demo app at: http://ciena-frost.github.io/ember-frost-list/. The issue is: #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants