Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finite lists and pagination #70

Merged
merged 8 commits into from
Nov 23, 2016

Conversation

sglanzer-deprecated
Copy link
Contributor

This project uses semver, please check the scope of this pr:

  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Added a infinite=false option along with pagination controls

@sglanzer-deprecated
Copy link
Contributor Author

@juwara0 has graciously offered to fill in tests after the fact - took a quick stab at making the code clean - let me know if there are any blockers.

@coveralls
Copy link

coveralls commented Nov 23, 2016

Coverage Status

Changes Unknown when pulling 818f29a on sglanzer:master into ** on ciena-frost:master**.

@TheOtherDude
Copy link
Contributor

Looks good, but note that this was a breaking change for our app. We're computing listItems from a route's model, and listItems is undefined before the model resolves in this version, but it was not an issue in 3.0.0. It's an easy fix that we wouldn't have even noticed with more defensive programming, but I wanted to mention it in case it affects other apps.

Other than that 👍

@sglanzer-deprecated
Copy link
Contributor Author

sglanzer-deprecated commented Nov 23, 2016

Approved

Approved with PullApprove

@sglanzer-deprecated sglanzer-deprecated merged commit d05c463 into ciena-frost:master Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants