-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use flexbox to layout list #75
Conversation
This is fine, but I'm a little wary about making it a patch - the switch to 100% height on the list may burn some downstream consumers that based their CSS on the previous setup. Can we get confirmation of the impact of this on one of our major apps? If it's no impact, then go with the fix, otherwise go major |
Changes Unknown when pulling 1b41b72 on quincyle:develop into ** on ciena-frost:master**. |
1 similar comment
Changes Unknown when pulling 1b41b72 on quincyle:develop into ** on ciena-frost:master**. |
@sglanzer You're right, it might have some unexpected impact on our downstream apps. Actually, this 100% on list root is not related the flexbox change, it is just something I feel we're missing previously (a default height for list), so I added it. I can just take it out for now and address later. |
Changes Unknown when pulling 1b41b72 on quincyle:develop into ** on ciena-frost:master**. |
Changes Unknown when pulling 27241a9 on quincyle:develop into ** on ciena-frost:master**. |
1 similar comment
Changes Unknown when pulling 27241a9 on quincyle:develop into ** on ciena-frost:master**. |
Changes Unknown when pulling 42c77c2 on quincyle:develop into ** on ciena-frost:master**. |
This project uses semver, please check the scope of this pr:
CHANGELOG