Skip to content

Commit

Permalink
Merge pull request #193 from juwara0/mochaDeprecations
Browse files Browse the repository at this point in the history
update usage of deprecated describeComponent and describeModule methods
  • Loading branch information
juwara0 committed Feb 7, 2017
2 parents f97b4f6 + ac54c2b commit 4c2442a
Show file tree
Hide file tree
Showing 15 changed files with 378 additions and 465 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"ember-redux": "^1.0.0",
"ember-resolver": "^2.0.3",
"ember-sinon": "~0.5.0",
"ember-test-utils": "^1.8.0",
"ember-truth-helpers": "1.2.0",
"eslint": "^3.0.0",
"eslint-config-frost-standard": "^4.0.0",
Expand Down
66 changes: 30 additions & 36 deletions tests/integration/components/nav-action-test.js
Original file line number Diff line number Diff line change
@@ -1,40 +1,34 @@
import { expect } from 'chai'
import { $hook, initialize } from 'ember-hook'
import {expect} from 'chai'
import {$hook, initialize} from 'ember-hook'
import sinon from 'sinon'
import {
describeComponent,
it
} from 'ember-mocha'
import { beforeEach } from 'mocha'
import hbs from 'htmlbars-inline-precompile'
import {beforeEach, describe, it} from 'mocha'

describeComponent(
'nav-action',
'Integration: NavActionComponent',
{
integration: true
},
function () {
beforeEach(function () {
initialize()
})
it('renders', function () {
this.render(hbs`{{nav-action}}`)
expect(this.$()).to.have.length(1)
})
it('calls perform action', function () {
let nav = Ember.Object.create({
performAction: sinon.spy()
})
this.set('_nav', nav)
this.set('_item', 'test')
this.render(hbs`{{nav-action
frostNavigation=_nav
item=_item
hook='nav-action'
}}`)
$hook('nav-action').click()
expect(nav.performAction.called).to.be.true
import {integration} from 'dummy/tests/helpers/ember-test-utils/setup-component-test'

const test = integration('nav-action')
describe(test.label, function () {
test.setup()

beforeEach(function () {
initialize()
})
it('renders', function () {
this.render(hbs`{{nav-action}}`)
expect(this.$()).to.have.length(1)
})
it('calls perform action', function () {
let nav = Ember.Object.create({
performAction: sinon.spy()
})
}
)
this.set('_nav', nav)
this.set('_item', 'test')
this.render(hbs`{{nav-action
frostNavigation=_nav
item=_item
hook='nav-action'
}}`)
$hook('nav-action').click()
expect(nav.performAction.called).to.be.true
})
})
90 changes: 41 additions & 49 deletions tests/integration/components/nav-category-test.js
Original file line number Diff line number Diff line change
@@ -1,53 +1,45 @@
import { expect } from 'chai'
import { $hook, initialize } from 'ember-hook'
import {
describeComponent,
it
} from 'ember-mocha'
import {
describe,
beforeEach
} from 'mocha'
import {expect} from 'chai'
import {$hook, initialize} from 'ember-hook'
import hbs from 'htmlbars-inline-precompile'
describeComponent(
'nav-category',
'Integration: NavCategoryComponent',
{
integration: true
},
function () {
beforeEach(function () {
initialize()
import {beforeEach, describe, it} from 'mocha'

import {integration} from 'dummy/tests/helpers/ember-test-utils/setup-component-test'

const test = integration('nav-category')
describe(test.label, function () {
test.setup()

beforeEach(function () {
initialize()
})
it('renders', function () {
this.render(hbs`{{nav-category}}`)
expect(this.$()).to.have.length(1)
})
describe('clicks', function () {
const helper = function (name, _activeCategory) {
this.set('_name', name)
this.set('_nav', Ember.Object.create({
_activeCategory,
dismiss () {
this.set('_activeCategory', null)
}
}))
this.render(hbs`{{nav-category
name=_name
frostNavigation=_nav
hook='nav-category'
}}`)
$hook('nav-category').click()
}
it('handles null case', function () {
helper.call(this, 'test', null)
})
it('renders', function () {
this.render(hbs`{{nav-category}}`)
expect(this.$()).to.have.length(1)
it('handles not equal case', function () {
helper.call(this, 'test', '_test')
})
describe('clicks', function () {
const helper = function (name, _activeCategory) {
this.set('_name', name)
this.set('_nav', Ember.Object.create({
_activeCategory,
dismiss () {
this.set('_activeCategory', null)
}
}))
this.render(hbs`{{nav-category
name=_name
frostNavigation=_nav
hook='nav-category'
}}`)
$hook('nav-category').click()
}
it('handles null case', function () {
helper.call(this, 'test', null)
})
it('handles not equal case', function () {
helper.call(this, 'test', '_test')
})
it('handles equal case', function () {
helper.call(this, 'test', 'test')
})
it('handles equal case', function () {
helper.call(this, 'test', 'test')
})
}
)
})
})
47 changes: 21 additions & 26 deletions tests/integration/components/nav-modal-outlet-test.js
Original file line number Diff line number Diff line change
@@ -1,30 +1,25 @@
/* jshint expr:true */
import { expect } from 'chai'
import {
describeComponent,
it
} from 'ember-mocha'
import {expect} from 'chai'
import hbs from 'htmlbars-inline-precompile'
import {describe, it} from 'mocha'

describeComponent(
'nav-modal-outlet',
'Integration: NavModalOutletComponent',
{
integration: true
},
function () {
it('renders', function () {
// Set any properties with set(this, 'myProperty', 'value');
// Handle any actions with this.on('myAction', function(val) { ... });
// Template block usage:
// this.render(hbs`
// {{#nav-modal-outlet}}
// template content
// {{/nav-modal-outlet}}
// `);
import {integration} from 'dummy/tests/helpers/ember-test-utils/setup-component-test'

this.render(hbs`{{nav-modal-outlet}}`)
expect(this.$()).to.have.length(1)
})
}
)
const test = integration('nav-modal-outlet')
describe(test.label, function () {
test.setup()

it('renders', function () {
// Set any properties with set(this, 'myProperty', 'value');
// Handle any actions with this.on('myAction', function(val) { ... });
// Template block usage:
// this.render(hbs`
// {{#nav-modal-outlet}}
// template content
// {{/nav-modal-outlet}}
// `);

this.render(hbs`{{nav-modal-outlet}}`)
expect(this.$()).to.have.length(1)
})
})
57 changes: 26 additions & 31 deletions tests/integration/components/nav-modal-test.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import {expect} from 'chai'
import Ember from 'ember'
import { expect } from 'chai'
import {
describeComponent,
it
} from 'ember-mocha'
import hbs from 'htmlbars-inline-precompile'
import {describe, it} from 'mocha'

import {integration} from 'dummy/tests/helpers/ember-test-utils/setup-component-test'

const {
run
Expand All @@ -14,31 +13,27 @@ const {
next
} = run

describeComponent(
'nav-modal',
'Integration: NavModalComponent',
{
integration: true
},
function () {
it('renders', function () {
this.render(hbs`{{nav-modal}}`)
expect(this.$()).to.have.length(1)
const test = integration('nav-modal')
describe(test.label, function () {
test.setup()

it('renders', function () {
this.render(hbs`{{nav-modal}}`)
expect(this.$()).to.have.length(1)
})
it('recomputes on _activeCategory change', function (done) {
let obj = Ember.Object.create({
_activeCategory: 'test'
})
it('recomputes on _activeCategory change', function (done) {
let obj = Ember.Object.create({
_activeCategory: 'test'
})
this.set('_nav', obj)
this.render(hbs`{{nav-modal
frostNavigation=_nav
activeCategory=activeCategory
}}`)
obj.set('_activeCategory', 'recompute')
next(() => {
expect(this.get('activeCategory')).to.equal('recompute')
done()
})
this.set('_nav', obj)
this.render(hbs`{{nav-modal
frostNavigation=_nav
activeCategory=activeCategory
}}`)
obj.set('_activeCategory', 'recompute')
next(() => {
expect(this.get('activeCategory')).to.equal('recompute')
done()
})
}
)
})
})
82 changes: 37 additions & 45 deletions tests/integration/components/nav-route-test.js
Original file line number Diff line number Diff line change
@@ -1,49 +1,41 @@
import { expect } from 'chai'
import { $hook, initialize } from 'ember-hook'

import {expect} from 'chai'
import Ember from 'ember'
import {$hook, initialize} from 'ember-hook'
import hbs from 'htmlbars-inline-precompile'
import {beforeEach, describe, it} from 'mocha'
import sinon from 'sinon'

import {
describeComponent,
it
} from 'ember-mocha'
import { beforeEach } from 'mocha'
import hbs from 'htmlbars-inline-precompile'
import Ember from 'ember'
import {integration} from 'dummy/tests/helpers/ember-test-utils/setup-component-test'

describeComponent(
'nav-route',
'Integration: NavRouteComponent',
{
integration: true
},
function () {
beforeEach(function () {
initialize()
})
it('renders', function () {
this.render(hbs`{{nav-route}}`)
expect(this.$()).to.have.length(1)
})
it('handles click, and dismiss', function () {
let nav = Ember.Object.create({
dismiss: sinon.spy(),
transitionTo: sinon.spy()
})
this.set('_nav', nav)
this.render(hbs`{{nav-route
frostNavigation=_nav
route='test'
hook='nav-route'
}}`)
const e = (o) => Ember.$.Event('click', o)
;[
e({shiftKey: true}),
e({metaKey: true}),
e({ctrlKey: true}),
e()
].forEach(e => $hook('nav-route').trigger(e))
expect(nav.dismiss.calledThrice).to.be.true
const test = integration('nav-route')
describe(test.label, function () {
test.setup()

beforeEach(function () {
initialize()
})
it('renders', function () {
this.render(hbs`{{nav-route}}`)
expect(this.$()).to.have.length(1)
})
it('handles click, and dismiss', function () {
let nav = Ember.Object.create({
dismiss: sinon.spy(),
transitionTo: sinon.spy()
})
}
)
this.set('_nav', nav)
this.render(hbs`{{nav-route
frostNavigation=_nav
route='test'
hook='nav-route'
}}`)
const e = (o) => Ember.$.Event('click', o)
;[
e({shiftKey: true}),
e({metaKey: true}),
e({ctrlKey: true}),
e()
].forEach(e => $hook('nav-route').trigger(e))
expect(nav.dismiss.calledThrice).to.be.true
})
})
Loading

0 comments on commit 4c2442a

Please sign in to comment.