Addressing problems with nav-entries with query params #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 846f526 on srowhani:feature/query-params into ** on ciena-frost:master**. |
rox163
reviewed
Nov 30, 2016
| @@ -21,6 +22,31 @@ export default Controller.extend({ | |||
| clearDuration: 1000 | |||
| }) | |||
| }, | |||
| init () { | |||
| this._super(...arguments) | |||
| let customRouteObject = Ember.Object.extend({ | |||
There was a problem hiding this comment.
we expect the user to override the init hook to get custom route with query params? Doesn't seem the nicest way.
There was a problem hiding this comment.
This is just there as an example to illustrate adding routes dynamically, and updating a given route when certain properties are recomputed (ex. query params).
Doesn't have to happen on the init hook.
|
Changes Unknown when pulling 08a70a6 on srowhani:feature/query-params into ** on ciena-frost:master**. |
|
Sorry I didn't get around to this sooner - thanks for doing review Roxanne - looks good, thanks Seena |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project uses semver, please check the scope of this pr:
CHANGELOG
params, of type hash that abuses ember's LinkTo Components way of parsing query params to allow for dynamic query parameters.