First 8.0 stuff #210
Merged
First 8.0 stuff #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
job13er
commented
Jun 25, 2017
| @@ -101,6 +93,6 @@ | |||
| "name": "frost-nav" | |||
| }, | |||
| "pr-bumper": { | |||
| "coverage": 95.24 | |||
| "coverage": 69.61 | |||
There was a problem hiding this comment.
Sadly, this is the actual accurate coverage information. The version of ember-cli-code-coverage we were using previously doesn't count coverage for modules that weren't loaded in test, so anything we were missing tests for wasn't reported properly. I also moved some .skip'd tests up from the it to the describe to more accurately reflect components we had no tests for.
|
Changes Unknown when pulling f3c3dfa on job13er:first-8.0-stuff into ** on ciena-frost:8.0-beta**. |
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project uses semver, please check the scope of this pr:
CHANGELOG
hookandhookQualifiersusage to align with best practices.ember-cli-code-coverageto get accurate coverage numbers