Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nav category icons to be specified as a path like nav-route icons #225

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Allow nav category icons to be specified as a path like nav-route icons #225

merged 2 commits into from
Nov 21, 2017

Conversation

TheOtherDude
Copy link
Contributor

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

This is the same as PR #221 except for category icons instead of route icons.

CHANGELOG

  • Added ability to specify category icons as urls, mirroring the functionality already implement for route icons.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f40857b on TheOtherDude:category-icon-urls into ** on ciena-frost:master**.

@notmessenger
Copy link
Contributor

notmessenger commented Nov 21, 2017 •
edited by dafortin
Loading

👍

Approved with PullApprove

@TheOtherDude TheOtherDude merged commit 86f5190 into ciena-frost:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmessenger notmessenger Awaiting requested review from notmessenger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheOtherDude @coveralls @notmessenger