Update dependencies #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling e5750ee on juwara0:updateDependencies into ** on ciena-frost:master**. |
|
Remove /visual-acceptance from .npmignore |
|
In addon/components/frost-popover.js can you please remove line 87 and 128 and remove the |
|
Changes Unknown when pulling 734284b on juwara0:updateDependencies into ** on ciena-frost:master**. |
notmessenger
reviewed
Jan 9, 2018
| @@ -3,12 +3,6 @@ const EmberAddon = require('ember-cli/lib/broccoli/ember-addon') | |||
|
|
|||
| module.exports = function (defaults) { | |||
| let app = new EmberAddon(defaults, { | |||
| babel: { | |||
| optional: ['es7.decorators'] | |||
There was a problem hiding this comment.
Don't still need this? I have not been checking for this entry in the other repos we've been updating.
There was a problem hiding this comment.
It is needed for ember-computed-decorators which is not being used in this add-on.
|
👍 |
|
Changes Unknown when pulling 8de4cf0 on juwara0:updateDependencies into ** on ciena-frost:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project uses semver, please check the scope of this pr:
Closes: #61
CHANGELOG
ember-frost-test@^4.0.0chai-jquery@^2.0.0ember-cli-chaito0.4.3ember-cli-code-coverage@0.3.12ember-cli-mochato0.14.4ember-hook@1.4.2ember-sinon@^0.7.0ember-test-utilsto^8.1.0sinon-chai@^2.14.0package-lock.jsonuntil we are ready to move to node 8ember-cli-build.jsember-cli-frost-blueprintsto^5.0.1ember-computed-decoratorsand removed necessary babel configember-concurrencyto be a dependency instead of devDependencyember-elsewherepackageember-prop-typesto^6.0.1and moved to dependency instead of devDependencyember-spreadpackageember-truth-helperspackageember-cli-sassto7.1.1ember-frost-coreto^5.0.0.eslintrcfile which has now been replaced by.eslintrc.js.remarkrcfile since it is now provided byember-test-utils