Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updates to get code coverage working #57

Merged
merged 6 commits into from Mar 13, 2017

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented Mar 10, 2017

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Updated the travis.yml and package.json to run code coverage

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a15bc68 on juwara0:fixCoverage into ** on ciena-frost:master**.

@juwara0
Copy link
Contributor Author

juwara0 commented Mar 13, 2017

👍

Approved with PullApprove

@juwara0 juwara0 merged commit 23caecd into ciena-frost:master Mar 13, 2017
@juwara0 juwara0 deleted the fixCoverage branch March 13, 2017 18:22
@juwara0
Copy link
Contributor Author

juwara0 commented Mar 13, 2017

Ember 2.11.3 introduced a BUGFIX: emberjs/ember.js#14898 that is is causing tests with .to.throw() to fail. There is an issue open to update ember-mocha: emberjs/ember-mocha#141 which may end up being moved to chai that may fix this issue for us. In the meantime, I am pinning to Ember 2.11.2 until we see how this plays out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants