Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proptypes #19

Merged
merged 6 commits into from
Jun 9, 2017
Merged

Fix proptypes #19

merged 6 commits into from
Jun 9, 2017

Conversation

job13er
Copy link
Contributor

@job13er job13er commented Jun 8, 2017

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

I started cleaning this up, b/c I believed the prop types needed to be updated, because I was getting warnings in my app, but now I'm not seeing them, so I figured I'd just submit the cleanup.

CHANGELOG

  • Enabled code coverage checks
  • Enabled throwing errors when proptypes finds problems (instead of warnings)
  • Upgraded ember-test-utils to 5.x

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3b3dba4 on job13er:fix-proptypes into ** on ciena-frost:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 12e0772 on job13er:fix-proptypes into ** on ciena-frost:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e9c3d48 on job13er:fix-proptypes into ** on ciena-frost:master**.

@job13er
Copy link
Contributor Author

job13er commented Jun 9, 2017

This looks like a big PR with 47 files changed, but they are all very minor changes. Mainly adding hooks where they were missing and reorganizing the propTypes sections (using a shared prop type from typedefs instead of re-defining it in multiple components, and fixing ordering of properties).

@sglanzer-deprecated
Copy link
Contributor

sglanzer-deprecated commented Jun 9, 2017

Approved

Approved with PullApprove

@sglanzer-deprecated sglanzer-deprecated merged commit 824727f into ciena-frost:master Jun 9, 2017
@job13er job13er deleted the fix-proptypes branch June 9, 2017 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants