Make selection behaviour match ember-frost-list #28
Conversation
|
Changes Unknown when pulling b97848c on AdamWard1995:fix_selection into ** on ciena-frost:master**. |
There was a problem hiding this comment.
I don't use table selection, and am not familiar with the implementation/behavior in frost-list, so I'm probably not the best reviewer for this. Looks like @quincyle is the biggest contributor on ember-frost-list, so maybe he can take a peek.
| }, | ||
|
|
||
| willDestroy () { | ||
| $(document).off(`keyup.${this.elementId} keydown.${this.elementId}`, this._keyHandler) |
There was a problem hiding this comment.
Should we release the bind on the destroy?
There was a problem hiding this comment.
Definitiely missing call to _super, but not sure what you mean by if we should release the binding on destroy. This is what we do in ember-frost-list https://github.com/ciena-frost/ember-frost-list/blob/master/addon/components/frost-list.js#L162 and it seems like the logical hook to do this https://guides.emberjs.com/v2.14.0/components/the-component-lifecycle/#toc_detaching-and-tearing-down-component-elements-with-code-willdestroyelement-code
|
Changes Unknown when pulling 01d052d on AdamWard1995:fix_selection into ** on ciena-frost:master**. |
|
Changes Unknown when pulling b1e11f3 on AdamWard1995:fix_selection into ** on ciena-frost:master**. |
|
Approved |
This project uses semver, please check the scope of this pr:
This PR prevents text from being selected when doing a range select and when clicking on a row body (as opposed to the checkbox) that row will be the only selected one
CHANGELOG
ember-frost-list