Vertical tabs #64
Merged
Vertical tabs #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 5764ed6 on quincyle:vertical-tabs into ** on ciena-frost:master**. |
|
Approved |
juwara0
suggested changes
Sep 26, 2017
.travis.yml
Outdated
| @@ -16,10 +16,6 @@ addons: | |||
| - g++-4.8 | |||
| firefox: 'latest' | |||
|
|
|||
| cache: | |||
There was a problem hiding this comment.
We want to leave this cache in. Please do not remove it.
juwara0
reviewed
Sep 26, 2017
| @@ -51,6 +51,7 @@ describe(test.label, function () { | |||
| }) | |||
|
|
|||
| it('Renders', function (done) { | |||
| this.timeout(5000) | |||
There was a problem hiding this comment.
Instead of setting a timeout, this should be written as a describe with a beforeEach() where the setProperties() and render() are handled and the expects() are inside the it(). If needed you can then put the return wait() in the beforeEach.
There was a problem hiding this comment.
describe('when something is done', function() {
beforeEach(function () {
this.setProperties({})
this.render()
return wait()
})
it('should have expected outcome', function () {
expect()
})
})
juwara0
approved these changes
Sep 26, 2017
|
Changes Unknown when pulling cd53042 on quincyle:vertical-tabs into ** on ciena-frost:master**. |
|
Changes Unknown when pulling c3bfda6 on quincyle:vertical-tabs into ** on ciena-frost:master**. |
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project uses semver, please check the scope of this pr:
CHANGELOG