Detail tabs #66
Detail tabs #66
Conversation
ember-cli-build.js
Outdated
| @@ -1,8 +1,11 @@ | |||
| /* eslint-env node */ | |||
| const EmberAddon = require('ember-cli/lib/broccoli/ember-addon') | |||
| const EmberApp = require('ember-cli/lib/broccoli/ember-addon') | |||
There was a problem hiding this comment.
Please revert this change. This is an EmberAddon not an EmberApp.
There was a problem hiding this comment.
Sorry ..big mistake .. Thanks for this comment.. I is done
ember-cli-build.js
Outdated
|
|
||
| module.exports = function (defaults) { | ||
| var app = new EmberAddon(defaults, { | ||
| var app = new EmberApp(defaults, { |
There was a problem hiding this comment.
EmberAddon instead of EmberApp.
package.json
Outdated
| "ember-load-initializers": "^0.6.0", | ||
| "ember-load-initializers": "0.6.3", | ||
| "ember-math-helpers": "2.1.0", | ||
| "ember-elsewhere": "1.0.1", |
There was a problem hiding this comment.
This got moved but is now not in alphabetical order. Please alphabetize.
package.json
Outdated
| "ember-export-application-global": "^1.0.5", | ||
| "ember-disable-proxy-controllers": "^1.0.1", | ||
| "ember-element-resize-detector": "0.1.5", | ||
| "ember-export-application-global": "^1.1.1", |
There was a problem hiding this comment.
Please leave this at: "ember-export-application-global": "^1.0.5",
package.json
Outdated
| @@ -48,10 +48,14 @@ | |||
| "ember-computed-decorators": "0.3.0", | |||
| "ember-concurrency": "0.7.19", | |||
| "ember-disable-prototype-extensions": "^1.1.0", | |||
| "ember-elsewhere": "1.0.1", | |||
| "ember-export-application-global": "^1.0.5", | |||
| "ember-disable-proxy-controllers": "^1.0.1", | |||
There was a problem hiding this comment.
This should not be necessary since this has been gone since Ember 2.0: https://github.com/cibernox/ember-disable-proxy-controllers#ember-disable-proxy-controllers
| }) | ||
| }) | ||
|
|
||
| it('should have slected tab by default', function () { |
There was a problem hiding this comment.
Spelling: slected should be selected.
| _subtabs (subtabs) { | ||
| if (isEmpty(subtabs) || typeOf(subtabs[0]) === 'object' || typeOf(subtabs[0]) === 'instance') { | ||
| // const isMissingProperties = subtabs.some(({id, label, icon, pack}) => { | ||
| // return !id || !label |
There was a problem hiding this comment.
Please remove the commented code if it is not needed.
|
|
||
| // == Computed Properties =================================================== | ||
|
|
||
| // Wrap selectedTab for the same reasons outlined in the comments for _tabs |
There was a problem hiding this comment.
Is the comment for _tabs that this comment references still in the code base? What happens if that comment were to be deleted or is already deleted? Instead, it would be better to add the comment block here as well.
addon/components/frost-detail-tab.js
Outdated
| // This is annoying, but the math appears to be slightly off, maybe because of the border | ||
| // between the tabs - so we're dropping one off the tabLeft for the border. | ||
| // Why the viewport needs another pixel for this to calculate correctly, I don't know... | ||
| // TODO Find out why... |
There was a problem hiding this comment.
Please put your username and date against this TODO and open an issue as well.
| // == Keyword Properties ==================================================== | ||
|
|
||
| layout, | ||
| tagName: '', |
There was a problem hiding this comment.
Can this be changed to a span maybe?
|
Changes Unknown when pulling ca019b5 on sunglam:detail-tabs into ** on ciena-frost:master**. |
|
👍 |
#minor#
CHANGELOG