Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version ember-frost-core #70

Merged
merged 2 commits into from
Nov 8, 2017
Merged

update version ember-frost-core #70

merged 2 commits into from
Nov 8, 2017

Conversation

EWhite613
Copy link
Contributor

@EWhite613 EWhite613 commented Nov 6, 2017 •
edited
Loading

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Use the latest ember-frost-core, with a flexible minor version (^3.0.1)

@juwara0
Copy link
Contributor

juwara0 commented Nov 6, 2017

The blueprint will need to be updated as well.

notmessenger
notmessenger suggested changes Nov 6, 2017
View reviewed changes
Copy link
Contributor

@notmessenger notmessenger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The blueprint needs to be updated as well.
  • Your Changelog entry is not accurate - you are using latest major
  • This PR cannot be a patch - you have changed a dependency to a new major.

@juwara0
Copy link
Contributor

juwara0 commented Nov 6, 2017

This will need to be a server major since you are moving the version of core up a major.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bfc8933 on EWhite613:up-everything into ** on ciena-frost:master**.

@EWhite613 EWhite613 mentioned this pull request Nov 6, 2017
Merged
4 tasks
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6d6344f on EWhite613:up-everything into ** on ciena-frost:master**.

@notmessenger
Copy link
Contributor

notmessenger commented Nov 7, 2017 •
edited by dafortin
Loading

👍

Approved with PullApprove

@EWhite613 EWhite613 merged commit 9d4ec60 into ciena-frost:master Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmessenger notmessenger notmessenger approved these changes

@juwara0 juwara0 Awaiting requested review from juwara0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EWhite613 @juwara0 @coveralls @notmessenger