Updating major versions of dependencies #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "babel-eslint": "^4.1.7", | ||
| "eslint-config-standard": "^4.4.0", | ||
| "babel-eslint": "^5.0.0", | ||
| "eslint-config-standard": "^5.1.0", | ||
| "eslint-plugin-standard": "^1.3.1" |
There was a problem hiding this comment.
The plugin doesn't need updating?
There was a problem hiding this comment.
It's up to date - that's the latest
|
I updated the team Developers to have permissions for this repo, so the pull approve should work if you throw another commit on here. |
|
Cool, I wasn't sure how far you wanted to expand privileges |
|
Looks like I'm missing a new peer dependency anyway |
| "babel-eslint": "^4.1.7", | ||
| "eslint-config-standard": "^4.4.0", | ||
| "babel-eslint": "^5.0.0", | ||
| "eslint-config-standard": "^5.1.0", |
There was a problem hiding this comment.
Looks like this may require another dependency now
https://travis-ci.org/ciena-frost/eslint-config-frost-standard/builds/109890304
Error: Failed to load plugin promise: Cannot find module 'eslint-plugin-promise'
|
Good to go? |
sglanzer-deprecated
pushed a commit
that referenced
this pull request
Feb 17, 2016
Updating major versions of dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a #major# change to move up the next versions of eslint and associated projects