Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint@3.x and mocha rules #20

Merged
merged 2 commits into from
Jul 15, 2016
Merged

eslint@3.x and mocha rules #20

merged 2 commits into from
Jul 15, 2016

Conversation

job13er
Copy link
Contributor

@job13er job13er commented Jul 15, 2016

This is a #major# change, b/c we switch to new major version of eslint

CHANGELOG

Breaking changes

  • Switched to eslint@3.x

New Rules

  • Added rule to error on a describe.only or describeComponent.only in tests
  • Added rule to warn on a describe.skip or it.skip (with --fix option 馃槃 )
  • Added rule to error on an it('pending test') with no test
  • Added rule to error on a global it()(not within a test suite)
  • Added rule to error if the done callback isn't called when it's defined.

@coveralls
Copy link

coveralls commented Jul 15, 2016

Coverage Status

Changes Unknown when pulling a05c486 on job13er:add-mocha-rules into * on ciena-frost:master*.

@sandersky
Copy link
Contributor

sandersky commented Jul 15, 2016

馃憤

Approved with PullApprove

@job13er
Copy link
Contributor Author

job13er commented Jul 15, 2016

馃憤

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants