Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub templates to reflect most recent desired content #54

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

notmessenger
Copy link
Contributor

Overview

Does this PR close an existing issue?

No

Summary

Provide a general summary of the issue addressed in the title above

Issue Number(s)

n/a/

Screenshots or recordings

Please provide screenshots or recordings if this PR is modifying the visual UI or UX.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have evaluated if the README.md documentation needs to be updated
  • I have evaluated if DocBlock headers needed to be added or updated
  • I have verified that lint and tests pass locally with my changes
  • If a fork of a dependent package had to be made to address the issue this PR closes:
    • I noted in the fork's README.md the reason the fork was created
    • I have opened an upstream issue detailing what was deficient about the dependency
    • I have opened an upstream PR addressing this deficiency
    • I have opened an issue in this repository to track this PR and schedule the removal of the usage of the fork

Semver

This project uses semver, please check the scope of this PR:

  • #none#
  • #patch#
  • #minor#
  • #major#

Examples:

  • NONE
    • README.md changes
    • test additions
    • changes to files that are not used by a consuming application (.travis.yml, .gitignore, etc)
  • PATCH
    • backwards-compatible bug fix
      • nothing about how to use the code has changed
      • nothing about the outcome of the code has changed (though it likely corrected it)
  • MINOR
    • adding functionality in a backwards-compatible manner
      • nothing about how used to use the code has changed but using it in a new way will do new things
      • nothing about the outcome of the code has changed without having to first use it in a new way
  • MAJOR
    • incompatible API change
      • using the code how used to will cease working
      • using the code how used to will have a different outcome

CHANGELOG

  • Update GitHub templates to reflect most recent desired content

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.0% when pulling c8f53ad on notmessenger:templates into 5eb2905 on ciena-frost:master.

@juwara0
Copy link
Contributor

juwara0 commented Mar 16, 2018

👍

Approved with PullApprove

@notmessenger notmessenger merged commit fd46361 into ciena-frost:master Mar 16, 2018
@notmessenger notmessenger deleted the templates branch March 16, 2018 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants