Protocol v1 support #134
Merged
Protocol v1 support #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix error with produce/response encode and decode handling for new version use pytest for tests update kafka and zk logs to go to file for tests test updates
mvaught02
force-pushed
the
protocol_v1_support
branch
from
a67e403
to
45e0f7f
Compare
ryban
reviewed
Jun 29, 2023
mvaught02
force-pushed
the
protocol_v1_support
branch
from
352fe53
to
7ddb4f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
few things for this PR
this will close #38
this will address parts of #133
added a client flag to enable broker aware request so that we will attempt to fetch and use the latest supported versions
(you have to use ProduceRequest v2 or higher to actually enable support for using message v1)
the integration tests now log to a file under the top level dir
logsonly the client logs to stdout for itests... the itests also now use pytest and if there is a failure the logs will be included in the test outputintegration tests now also run against broker version
2.8.2as well as still running against1.1.1and0.9.0.13.9.4will be added in the next PR that will include record/recordBatch handlingthere are several places where
magicwas added to the encoder to handle different ways the message might be built before passing it to the producer to to send but for anyone using the normalproducer.send_messagesthis should be handled automatically... if you use the low levelproducer.send_produce_requestthen you will need to update your code to pass in themagicto the messages you construct to pass to the ProduceRequest this would only be for the case where you want to use the non-defaulted value (always 0)