Issue#452

[jomorodi]

The CMakeLists.txt was modified because Ubuntu 22.04 version had gcc version 11 which did not have the header and did not compile on my machine so i changed the conditional to allow for it to use the fmt::format library
The modification lead to updating the FormatHelper.h header to reflect the changes. in addition The fmt library was also added as dependency to the test target to enable the test compile on my machine
Estonia locaction data was added which includes EstoniaAddresses EstoniaCounties EstoniaStreetNames EstoniaStreetSuffixes

test was appended to the end of LocationTest using the test for denmark as a template
estonia was included in AddressCountry enum
finally, The estonia data was gotten from resource available on the internet and google maps so their is no guarantee that all the information are correct as i do not live in estonia. "
[issue#452 1be61dd] introduction of estonian location data The CMakeLists.txt was modified because Ubuntu 22.04 version had gcc version 11 which did not have the header and did not compile on my machine so i changed the conditional to allow for it to use the fmt::format library The modification lead to updating the FormatHelper.h header to reflect the changes. in addition The fmt library was also added as dependency to the test target to enable the test compile on my machine Estonia locaction data was added which includes EstoniaAddresses EstoniaCounties EstoniaStreetNames EstoniaStreetSuffixes test was appended to the end of LocationTest using the test for denmark as a template estonia was included in AddressCountry enum finally, The estonia data was gotten from resource available on the internet and google maps so their is no guarantee that all the information are correct as i do not live in estonia.

Kind regards

[cieslarmichal]

Hello, good job! Please give a star to the repository to make the project more popular 🔥

[cieslarmichal]

Please fix failing pipelines

[cieslarmichal]

I think its wrong, msvc and clang supports std::format, you could specify it for some version of clan less than

[cieslarmichal]

I think clang and msvc should stay the same

[jomorodi]

I think clang and msvc should stay the same

okay i reverted back to the previos commit

[cieslarmichal]

Try to add more specified checks in format helper like defined(GNUC) && less than 12

[cieslarmichal]

Looks like in clang and msvc this if resolves to true and it tries to use fmt

[cieslarmichal]

Btw cant you install g++ 13? 😁

[jomorodi]

Try to add more specified checks in format helper like defined(GNUC) && less than 12
ah ok i see the bug now.

[cieslarmichal]

((defined(__GNUC__) && (__GNUC__ < 12)  && !defined(__clang__))

should work 😄

[jomorodi]

looks like clang also defines gnuc

[jomorodi]

Btw cant you install g++ 13? 😁

reason is i would need to use a third party ppa but i am trying to avoid any possible breaks on my OS. in addition , too lazy to manually compile the compiler . i do not understand the error message coming from msvc workflow i have not modified any of those document in this current branch. it could be an old issue

[cieslarmichal]

I know about msvc issue, if clang build will pass I will merge it :)

[cieslarmichal]

Issue is mentioned here: #469