Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/system #73

Merged
merged 16 commits into from
Jul 29, 2023
Merged

Conversation

shekeraoleksandr
Copy link
Contributor

Implemented all system features.

Also:

  • Add boolean method overload at the DataType class with probability parameter
  • Updated Helper class with objectKey and maybe methods
  • Add mac address generation at the Internet class
  • Add hexadecimal number generation

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.39% ⚠️

Comparison is base (78e2a5b) 98.11% compared to head (61e53c7) 97.73%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   98.11%   97.73%   -0.39%     
==========================================
  Files          20       22       +2     
  Lines        1593     1767     +174     
==========================================
+ Hits         1563     1727     +164     
- Misses         30       40      +10     
Files Changed Coverage Δ
include/faker-cxx/Number.h 75.00% <ø> (ø)
include/faker-cxx/Helper.h 100.00% <100.00%> (ø)
src/modules/datatype/DatatypeTest.cpp 100.00% <100.00%> (ø)
src/modules/helper/HelperTest.cpp 100.00% <100.00%> (ø)
src/modules/internet/InternetTest.cpp 100.00% <100.00%> (ø)
src/modules/number/NumberTest.cpp 100.00% <100.00%> (ø)
src/modules/system/SystemTest.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shekeraoleksandr
Copy link
Contributor Author

I'll solve all errors a little bit later

Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Small changes requested :)

include/faker-cxx/System.h Show resolved Hide resolved
src/modules/system/data/CronOptions.h Outdated Show resolved Hide resolved
src/modules/system/data/FileOptions.h Outdated Show resolved Hide resolved
src/modules/system/data/NetworkInterfaceOptions.h Outdated Show resolved Hide resolved
src/modules/system/data/CronOptions.h Outdated Show resolved Hide resolved
@shekeraoleksandr
Copy link
Contributor Author

Bit busy with other things :( so I'll do it tomorrow

@cieslarmichal
Copy link
Owner

Sure, no problem :)

Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move other needed types from header to include/types directory

@cieslarmichal cieslarmichal merged commit ab2ca46 into cieslarmichal:main Jul 29, 2023
3 checks passed
@cieslarmichal cieslarmichal mentioned this pull request Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants