-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/system #73
Feature/system #73
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 98.11% 97.73% -0.39%
==========================================
Files 20 22 +2
Lines 1593 1767 +174
==========================================
+ Hits 1563 1727 +164
- Misses 30 40 +10
☔ View full report in Codecov by Sentry. |
I'll solve all errors a little bit later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Small changes requested :)
Bit busy with other things :( so I'll do it tomorrow |
Sure, no problem :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move other needed types from header to include/types directory
Implemented all system features.
Also: