Added iban support for missing eu members #74
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 98.30% 96.98% -1.33%
==========================================
Files 22 22
Lines 1767 1722 -45
==========================================
- Hits 1737 1670 -67
- Misses 30 52 +22
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks for contributing! We have a discord channel for contributors if you want to join us: here. Feel free to refactor iban tests. Please look at the comment I added about adding new countries to supported iban countries vector.
Added gmock neccessary for ASSERT_THAT
|
Good job, nice tests refactor but it fails in windows environment in cicd pipeline, could you please fix that? |
Link gmock for tests
Hey, I saw you'd like to have support for more IBANs. I've added the eu ones that were missing (to my best knowledge) and sorted the list alphabetically, so finding missing countries is a bit easier.
Currently, the tests for the new ibans are missing. I'd like to know if it would be ok for you to refactor the iban test, to make it parameterized and check if the generated iban is matched by a regular expression defined for each country. This would reduce the boilerplate code required to test a new iban. However, I would be fine to implement the tests the same way as the existing ones.