Long options don't work

[lpapadakos]

I tested this with ksmbd.control. -s works, but --shutdown gives me the usage message. It would seem that the way getopt is used, it only accepts short options

[alexmyczko]

I can confirm this to be the case for me as well with 3.4.2.

[namjaejeon]

Yep, right.
Enzo is trying to update the whole ksmbd-tools. He will fix it after that.
@ematsumiya Right ? and We need to add manpage also if you change single binary.

[ematsumiya]

That's right. A manpage and updated docs should also be included in the final version.
I'm on vacation now though, so please expect a ready-for-review version by the end of January.

[namjaejeon]

Cool! Have a good vacation:)

[namjaejeon]

@ematsumiya Hi Enzo, Is there any update for single binary work ?

[ematsumiya]

@namjaejeon I just sent my patch series to linux-cifs ML and you. It was based on ksmbd-tools-next branch.

manpage is still missing, but the README has been updated at least. I hope to have some time this week or next to work on the manpage.

@papadakospan @alexmyczko I'd appreciate if you could test my proposal, feedback is welcome. Source is at https://github.com/ematsumiya/ksmbd-tools/tree/ksmbdctl-v2-rebase

[lpapadakos]

It seems to work nicely, good work. You've included some useful features

EDIT:
The only minor thing I have is that whenever I start the kernel daemon, I get this

INFO: Can't open lock file /tmp/ksmbd.lock: No such file or directory

[namjaejeon]

@ematsumiya Thanks for your patches. I will check it.

[lpapadakos]

I have gotten global share options to work while I was exploring the v2 tree (Relevant: cifsd-team/ksmbd#516). I've made pull request #231

[namjaejeon]

It was based on ksmbd-tools-next branch.

@ematsumiya It would be good if you create the patch-set base on #master branch.

[lpapadakos]

@ematsumiya Your changes are very nice, Have you made a pull request or something towards this repo?

[ematsumiya]

Oops. Got side tracked yet again... sorry about the delay.

I think it's still required to base it on master, right @namjaejeon? I'll try to do it by tomorrow.

[namjaejeon]

@ematsumiya okay:) Thanks for your work!

[ematsumiya]

Submitted PR #265, rebased on cifsd-team/ksmbd-tools master. Testing and feedback appreciated.

[namjaejeon]

@ematsumiya Let me check it! Thanks!