Remove python 2 compatible module / imports #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was from cihai itself, it means we'll want to be strict about dependencies, 0.14.0+ of cihai won't have the PY2 import anymore.
This was referenced Aug 20, 2022
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 74.67% 75.44% +0.77%
==========================================
Files 5 5
Lines 229 224 -5
==========================================
- Hits 171 169 -2
+ Misses 58 55 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tony
added a commit
to cihai/unihan-etl
that referenced
this pull request
Aug 20, 2022
Python 2 compatibility was officially removed in 0.12.0 (2021-06-15) **#258, cihai/unihan-db#299, cihai/cihai#325, cihai/cihai-cli#278
tony
added a commit
to cihai/unihan-db
that referenced
this pull request
Aug 20, 2022
Python 2.x was officially dropped in 0.2.0 (2021-06-15) cihai/unihan-etl#258, **#299, cihai/cihai#325, cihai/cihai-cli#278
tony
added a commit
to cihai/cihai
that referenced
this pull request
Aug 20, 2022
Python 2.x was officially dropped in 0.11.0 (2021-06-15) cihai/unihan-etl#258, cihai/unihan-db#299, **#325, cihai/cihai-cli#278
tony
added a commit
to cihai/unihan-etl
that referenced
this pull request
Sep 2, 2023
Python 2 compatibility was officially removed in 0.12.0 (2021-06-15) **#258, cihai/unihan-db#299, cihai/cihai#325, cihai/cihai-cli#278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2.x was officially dropped in 0.7.0 (2021-06-15) via #278
This was from cihai itself, it means we'll want to be strict about dependencies, 0.14.0+ of cihai won't have the PY2 import anymore.
cihai/unihan-etl#258, cihai/unihan-db#299, cihai/cihai#325, #278