Linting: Aggressive ruff pass (ruff v0.3.4) #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony
force-pushed
the
ruff-all-v0.3.4-pass
branch
from
7bfe4c0
to
102e27e
Compare
ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; ruff format .
Fixed 9 errors:
- docs/conf.py:
1 × RET505 (superfluous-else-return)
- src/cihai_cli/cli.py:
1 × RET505 (superfluous-else-return)
- tests/conftest.py:
6 × PT001 (pytest-fixture-incorrect-parentheses-style)
1 × PT003 (pytest-extraneous-scope-function)
tony
force-pushed
the
ruff-all-v0.3.4-pass
branch
from
102e27e
to
e91a1d9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 75.09% 75.37% +0.28%
==========================================
Files 5 5
Lines 269 268 -1
==========================================
Hits 202 202
+ Misses 67 66 -1 ☔ View full report in Codecov by Sentry. |
tony
force-pushed
the
ruff-all-v0.3.4-pass
branch
from
39e7360
to
83495f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 9 errors:
1 × RET505 (superfluous-else-return)
1 × RET505 (superfluous-else-return)
6 × PT001 (pytest-fixture-incorrect-parentheses-style)
1 × PT003 (pytest-extraneous-scope-function)'