Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern setup: doctests, mypy, cached poetry #323

Merged
merged 17 commits into from Aug 16, 2022
Merged

Modern setup: doctests, mypy, cached poetry #323

merged 17 commits into from Aug 16, 2022

Conversation

tony
Copy link
Member

@tony tony commented Aug 16, 2022

Compare to #323, cihai/cihai-cli#276, cihai/unihan-etl#255, cihai/unihan-db#297

  • CI: Fix publishing docs only when changes detected
  • CI: Improve poetry dependency caching / CI speed
  • CI: Phase out .pre-commit-config.yaml
  • Testing: Add basic pytest configuration
  • Testing: Basic doctest support
  • Linting: Basic mypy static type checking

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #323 (d36cd45) into master (de7e68b) will decrease coverage by 5.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   89.41%   84.34%   -5.07%     
==========================================
  Files          16       17       +1     
  Lines         425      511      +86     
==========================================
+ Hits          380      431      +51     
- Misses         45       80      +35     
Impacted Files Coverage Δ
cihai/conversion.py 87.50% <ø> (ø)
docs/conf.py 59.30% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony merged commit 283fdb4 into master Aug 16, 2022
@tony tony deleted the modern branch August 16, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant