ci(ruff): Stricter code quality rules #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
- Coverage 84.75% 84.20% -0.56%
==========================================
Files 21 21
Lines 702 709 +7
==========================================
+ Hits 595 597 +2
- Misses 107 112 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tony
force-pushed
the
ruff-rules
branch
2 times, most recently
from
fbde364
to
e1e8a7a
Compare
Though we don't use that rule in settings due to us wanting to keep capitalization from UNIHAN and it not detecting classes when Automap is used.
tests/test_extend.py:51:5: B018 Found useless expression. Either assign it to a variable or remove it.
src/cihai/_internal/config_reader.py:49:19: TRY003 Avoid specifying long messages outside the exception class src/cihai/_internal/config_reader.py:112:19: TRY003 Avoid specifying long messages outside the exception class src/cihai/_internal/config_reader.py:187:19: TRY003 Avoid specifying long messages outside the exception class src/cihai/core.py:104:19: TRY003 Avoid specifying long messages outside the exception class Found 4 errors.
This was referenced Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs:
See also: #353, cihai/unihan-etl#290