Toughen rough linting #367

tony · 2024-02-08T11:30:52Z

Changes

ruff linting

flake8-commas (COM)

flake8-builtins (A)

flake8-errmsg (EM)

See also: - https://docs.astral.sh/ruff/rules/#flake8-commas-com - https://pypi.org/project/flake8-commas/ Ignoring COM812: - https://docs.astral.sh/ruff/formatter/#conflicting-lint-rules - https://docs.astral.sh/ruff/rules/missing-trailing-comma/

See also: - https://docs.astral.sh/ruff/rules/#flake8-builtins-a - https://pypi.org/project/flake8-builtins/

codecov · 2024-02-08T11:31:02Z

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7c65c03) 85.67% compared to head (c688f95) 85.67%.

Files	Patch %	Lines
src/cihai/_internal/config_reader.py	84.61%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files          21       21           
  Lines         705      705           
=======================================
  Hits          604      604           
  Misses        101      101

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/cihai/_internal/config_reader.py:16:24: A002 Argument `format` is shadowing a Python builtin src/cihai/_internal/config_reader.py:39:15: A002 Argument `format` is shadowing a Python builtin src/cihai/_internal/config_reader.py:62:19: A002 Argument `format` is shadowing a Python builtin src/cihai/_internal/config_reader.py:118:13: A001 Variable `format` is shadowing a Python builtin src/cihai/_internal/config_reader.py:120:13: A001 Variable `format` is shadowing a Python builtin src/cihai/_internal/config_reader.py:171:9: A002 Argument `format` is shadowing a Python builtin src/cihai/_internal/config_reader.py:199:20: A002 Argument `format` is shadowing a Python builtin Found 7 errors.

See also: - https://docs.astral.sh/ruff/rules/#flake8-errmsg-em - https://pypi.org/project/flake8-errmsg/

tony added 4 commits February 8, 2024 04:55

ruff . --select COM --fix

8445128

ruff format (after adding flake8-commas)

b1ea9fd

pyproject(ruff): flake8-builtins

9e9214c

See also: - https://docs.astral.sh/ruff/rules/#flake8-builtins-a - https://pypi.org/project/flake8-builtins/

tony added 3 commits February 8, 2024 05:33

pyproject(ruff): Add flake8-errmsg

fede169

See also: - https://docs.astral.sh/ruff/rules/#flake8-errmsg-em - https://pypi.org/project/flake8-errmsg/

docs(CHANGES): Note linting improvements

c688f95

tony force-pushed the ruff-toughen branch from 6b18ef3 to c688f95 Compare February 8, 2024 11:33

tony merged commit 65e09c7 into master Feb 8, 2024
9 checks passed

tony deleted the ruff-toughen branch February 8, 2024 11:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Toughen rough linting #367

Toughen rough linting #367

tony commented Feb 8, 2024

codecov bot commented Feb 8, 2024 •

edited

Toughen rough linting #367

Toughen rough linting #367

Conversation

tony commented Feb 8, 2024

Changes

ruff linting

flake8-commas (COM)

flake8-builtins (A)

flake8-errmsg (EM)

codecov bot commented Feb 8, 2024 • edited

Codecov Report

codecov bot commented Feb 8, 2024 •

edited