Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve merge_dict typing #271

Merged
merged 2 commits into from May 13, 2023
Merged

chore: Improve merge_dict typing #271

merged 2 commits into from May 13, 2023

Conversation

tony
Copy link
Member

@tony tony commented May 13, 2023

No description provided.

@tony tony changed the title chore: Improve merge_dict typing chore: Improve merge_dict typing May 13, 2023
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #271 (49cc171) into master (7ae55a0) will increase coverage by 0.72%.
The diff coverage is 66.66%.

❗ Current head 49cc171 differs from pull request most recent head 0419604. Consider uploading reports for the commit 0419604 to get more accurate results

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   92.58%   93.31%   +0.72%     
==========================================
  Files          13       13              
  Lines        1025     1017       -8     
  Branches      133      122      -11     
==========================================
  Hits          949      949              
+ Misses         54       49       -5     
+ Partials       22       19       -3     
Impacted Files Coverage Δ
src/unihan_etl/util.py 55.55% <66.66%> (+7.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony merged commit 0c5b471 into master May 13, 2023
9 checks passed
@tony tony deleted the tn-improve-merge-dict branch May 13, 2023 12:46
tony added a commit that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant