Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctest examples #274

Merged
merged 16 commits into from Jun 17, 2023
Merged

doctest examples #274

merged 16 commits into from Jun 17, 2023

Conversation

tony
Copy link
Member

@tony tony commented Jun 11, 2023

Fixes #273

Changes

doctest

  • Add root-level conftest.py
  • Set gp-lib's doctest module

pytest plugin

  • Add unihan_etl.pytest_plugin / src/unihan_etl/pytest_plugin.py
  • Add tool.poetry.plugins.pytest11 to pyproject.toml
  • Move tests/conftest.py to src/unihan_etl/pytest_plugin.py

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Merging #274 (92ace5d) into master (2e63449) will decrease coverage by 22.85%.
The diff coverage is 18.51%.

@@             Coverage Diff             @@
##           master     #274       +/-   ##
===========================================
- Coverage   93.30%   70.45%   -22.85%     
===========================================
  Files          14        9        -5     
  Lines        1045      995       -50     
  Branches      175      180        +5     
===========================================
- Hits          975      701      -274     
- Misses         51      271      +220     
- Partials       19       23        +4     
Impacted Files Coverage Δ
src/unihan_etl/test.py 100.00% <ø> (ø)
src/unihan_etl/util.py 59.25% <ø> (+3.70%) ⬆️
src/unihan_etl/pytest_plugin.py 27.63% <18.51%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the doctests branch 2 times, most recently from 4e02243 to e28ebde Compare June 11, 2023 14:46
@tony tony force-pushed the doctests branch 9 times, most recently from 12fa057 to 41c1703 Compare June 12, 2023 11:58
@tony tony merged commit 9d9727e into master Jun 17, 2023
9 of 10 checks passed
@tony tony deleted the doctests branch June 17, 2023 19:10
tony added a commit that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

doctest examples
1 participant