Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typing library, typing as t #276

Merged
merged 6 commits into from Jun 11, 2023
Merged

Use typing library, typing as t #276

merged 6 commits into from Jun 11, 2023

Conversation

tony
Copy link
Member

@tony tony commented Jun 11, 2023

  • Use typing as t to namespace typing conveniently
  • Use TypedDict and Literal from typing (instead of typing_extensions) since we're on python 3.8

Extracted from #274

tony added 2 commits June 11, 2023 09:46
In some cases, e.g. TypedDict and Literal Python 3.8 includes these typings
without the need to use unihan_etl
@tony tony force-pushed the typing-namespace branch 2 times, most recently from dad981d to daffa10 Compare June 11, 2023 15:19
@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Merging #276 (e02edc7) into master (f84ed88) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   93.31%   93.28%   -0.04%     
==========================================
  Files          13       13              
  Lines        1017     1012       -5     
  Branches      172      172              
==========================================
- Hits          949      944       -5     
  Misses         49       49              
  Partials       19       19              
Impacted Files Coverage Δ
src/unihan_etl/test.py 100.00% <ø> (ø)
src/unihan_etl/expansion.py 100.00% <100.00%> (ø)
src/unihan_etl/process.py 85.39% <100.00%> (-0.07%) ⬇️
src/unihan_etl/types.py 100.00% <100.00%> (ø)
tests/test_expansion.py 98.52% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony merged commit c728d2c into master Jun 11, 2023
10 checks passed
@tony tony deleted the typing-namespace branch June 11, 2023 15:25
tony added a commit that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant