New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pathlib
, improve typings
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 93.28% 93.30% +0.02%
==========================================
Files 13 14 +1
Lines 1012 1045 +33
Branches 172 175 +3
==========================================
+ Hits 944 975 +31
- Misses 49 51 +2
Partials 19 19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tony
force-pushed
the
pathlib
branch
2 times, most recently
from
June 12, 2023 11:39
5bbff7a
to
2dc8c4b
Compare
Move imports into TYPE_CHECKING, use string notation
tony
added a commit
that referenced
this pull request
Sep 2, 2023
- Use `pathlib` for system file paths - Downloading: Improve typings of `urlretrieve_fn` and `reporthook` callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #278
pathlib
for system file pathsurlretrievefn
andreporthook