Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathlib, improve typings #277

Merged
merged 13 commits into from Jun 12, 2023
Merged

pathlib, improve typings #277

merged 13 commits into from Jun 12, 2023

Conversation

tony
Copy link
Member

@tony tony commented Jun 12, 2023

Fixes #278

  • Use pathlib for system file paths
  • Downloading: Improve typings of urlretrievefn and reporthook

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #277 (28104f2) into master (272f8a4) will increase coverage by 0.02%.
The diff coverage is 89.36%.

❗ Current head 28104f2 differs from pull request most recent head d9798b4. Consider uploading reports for the commit d9798b4 to get more accurate results

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   93.28%   93.30%   +0.02%     
==========================================
  Files          13       14       +1     
  Lines        1012     1045      +33     
  Branches      172      175       +3     
==========================================
+ Hits          944      975      +31     
- Misses         49       51       +2     
  Partials       19       19              
Impacted Files Coverage Δ
src/unihan_etl/process.py 85.58% <85.41%> (+0.19%) ⬆️
src/unihan_etl/types.py 93.54% <86.66%> (-6.46%) ⬇️
tests/test_unihan.py 96.49% <90.00%> (-0.03%) ⬇️
src/unihan_etl/app_dirs.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the pathlib branch 2 times, most recently from 5bbff7a to 2dc8c4b Compare June 12, 2023 11:39
@tony tony merged commit 65dbe95 into master Jun 12, 2023
9 checks passed
@tony tony deleted the pathlib branch June 12, 2023 11:55
tony added a commit that referenced this pull request Sep 2, 2023
- Use `pathlib` for system file paths
- Downloading: Improve typings of `urlretrieve_fn` and `reporthook` callbacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Move files to pathlib
1 participant