Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move options to dataclass #280

Merged
merged 5 commits into from Jun 17, 2023
Merged

Move options to dataclass #280

merged 5 commits into from Jun 17, 2023

Conversation

tony
Copy link
Member

@tony tony commented Jun 12, 2023

Fixes #279 by moving options to dataclass

@tony tony force-pushed the dataclass-config branch 3 times, most recently from 3d53c97 to 651e998 Compare June 17, 2023 15:08
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #280 (49d8e2d) into master (9d9727e) will decrease coverage by 1.00%.
The diff coverage is 52.17%.

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   70.45%   69.45%   -1.00%     
==========================================
  Files           9       10       +1     
  Lines         995     1005      +10     
  Branches      180      135      -45     
==========================================
- Hits          701      698       -3     
- Misses        271      282      +11     
- Partials       23       25       +2     
Impacted Files Coverage Δ
src/unihan_etl/options.py 0.00% <0.00%> (ø)
src/unihan_etl/pytest_plugin.py 28.37% <14.28%> (+0.74%) ⬆️
src/unihan_etl/process.py 61.46% <48.64%> (+1.64%) ⬆️
src/unihan_etl/util.py 51.78% <50.00%> (-7.48%) ⬇️
tests/test_unihan.py 96.55% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the dataclass-config branch 4 times, most recently from 790378a to e8b6cfb Compare June 17, 2023 18:11
@tony tony merged commit a61430b into master Jun 17, 2023
9 checks passed
@tony tony deleted the dataclass-config branch June 17, 2023 20:04
tony added a commit that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Use dataclass config object
1 participant