app_dirs: Add tests, allow configuration, template replacement
#287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 69.41% 70.70% +1.29%
==========================================
Files 10 12 +2
Lines 1007 1065 +58
Branches 182 196 +14
==========================================
+ Hits 699 753 +54
- Misses 283 284 +1
- Partials 25 28 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tony
force-pushed
the
app-dirs-configurable
branch
5 times, most recently
from
f1ab0fd
to
ca1ee6b
Compare
tony
force-pushed
the
app-dirs-configurable
branch
2 times, most recently
from
c41a074
to
b41dde4
Compare
tony
force-pushed
the
app-dirs-configurable
branch
from
b41dde4
to
158f39e
Compare
tony
force-pushed
the
app-dirs-configurable
branch
from
08c9b0e
to
f61fdff
Compare
tony
added a commit
that referenced
this pull request
Jun 24, 2023
tony
added a commit
that referenced
this pull request
Sep 2, 2023
#287) app_dirs: - Move from `unihan_etl` to `unihan_etl._internal` - Adds doctests - Normal pytests - Variable replacement
tony
added a commit
that referenced
this pull request
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppDirsshould allow:_internals/app_dirs.pydoctests