Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pytest[zshrc]): Fix skipif condition #292

Merged
merged 2 commits into from Jul 8, 2023
Merged

fix(pytest[zshrc]): Fix skipif condition #292

merged 2 commits into from Jul 8, 2023

Conversation

tony
Copy link
Member

@tony tony commented Jul 8, 2023

Would skip creation of .zshrc when not zsh (opposite of what's intended)

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #292 (b02c192) into master (3a93f96) will not change coverage.
The diff coverage is 0.00%.

❗ Current head b02c192 differs from pull request most recent head 7631117. Consider uploading reports for the commit 7631117 to get more accurate results

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   70.39%   70.39%           
=======================================
  Files          12       12           
  Lines        1064     1064           
  Branches      193      193           
=======================================
  Hits          749      749           
  Misses        287      287           
  Partials       28       28           
Impacted Files Coverage Δ
src/unihan_etl/pytest_plugin.py 28.37% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony merged commit 352dca3 into master Jul 8, 2023
8 checks passed
@tony tony deleted the fix-zshrc branch July 8, 2023 13:07
tony added a commit that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant