Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff: Enable pydocstyle w/ numpy convention #303

Merged
merged 25 commits into from Nov 26, 2023
Merged

ruff: Enable pydocstyle w/ numpy convention #303

merged 25 commits into from Nov 26, 2023

Conversation

tony
Copy link
Member

@tony tony commented Nov 26, 2023

`ruff --show-fixes --fix-only .`

Fixed 14 errors:
- src/unihan_etl/core.py:
    1 × D412 (blank-lines-between-header-and-content)
    1 × D209 (new-line-after-last-paragraph)
- src/unihan_etl/expansion.py:
    1 × D412 (blank-lines-between-header-and-content)
- tests/test_expansion.py:
    1 × D403 (first-line-capitalized)
- tests/test_unihan.py:
    9 × D202 (no-blank-line-after-function)
    1 × D403 (first-line-capitalized)

Fixed 14 errors (6 additional fixes available with `--unsafe-fixes`).
`ruff --show-fixes --fix-only --unsafe-fixes .`

Fixed 6 errors:
- conftest.py:
    1 × D400 (ends-in-period)
- docs/conf.py:
    1 × D400 (ends-in-period)
- src/unihan_etl/util.py:
    2 × D301 (escape-sequence-in-docstring)
    1 × D400 (ends-in-period)
- tests/test_expansion.py:
    1 × D400 (ends-in-period)

Fixed 6 errors.
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a894594) 67.79% compared to head (1b5be37) 67.79%.

Files Patch % Lines
src/unihan_etl/core.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   67.79%   67.79%           
=======================================
  Files          12       12           
  Lines        1149     1149           
  Branches      215      215           
=======================================
  Hits          779      779           
  Misses        317      317           
  Partials       53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony marked this pull request as ready for review November 26, 2023 16:45
@tony tony merged commit 6b9d0cb into master Nov 26, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant