Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(conf): CsvLexer: Fix with quotes #314

Merged
merged 2 commits into from Feb 9, 2024
Merged

Conversation

tony
Copy link
Member

@tony tony commented Feb 9, 2024

Context

Quoted text is not accounted for - groupings for syntax persists with commas:

image

image

Changes

CsvLexer: Handle quoted CSV items

With PR:

image

image

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a053e2) 67.16% compared to head (d7939dc) 67.16%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   67.16%   67.16%           
=======================================
  Files          12       12           
  Lines        1261     1261           
  Branches      231      231           
=======================================
  Hits          847      847           
  Misses        358      358           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony merged commit fa69ab4 into master Feb 9, 2024
12 checks passed
@tony tony deleted the docs-fix-csv-lexer-quotes branch February 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant