Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup spaces ? #111

Closed
ederag opened this issue Feb 27, 2022 · 1 comment · Fixed by #121
Closed

Cleanup spaces ? #111

ederag opened this issue Feb 27, 2022 · 1 comment · Fixed by #121

Comments

@ederag
Copy link
Contributor

ederag commented Feb 27, 2022

Spaces changes make PR difficult to review (e.g. #106),
(or to create, for those who take care to avoid space changes).
One way would be to add a .editorconfig file with the expected format.

On the same line, a code formatter such as black might help a lot.
https://deepsource.io/blog/python-code-formatters/

If you wish, I'd be glad to give more details about the procedure (very easy) and help with the review
(or file PRs if you prefer).

@ramezquitao
Copy link
Member

@ederag I just merged a repo where black was run to the python files, and some of the cython files were fixed using autopep8 with some relevant options. I just tested the merge with some of my complex projects, and everything seems to be running OK. Regarding the .editorconfig please add it if you can, or point me to the info to generate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants