Question: how to wrap seelog in own package?

[goodsign]

Hi there,

I want to use seelog in a mixed hosting environment: appengine and standalone.

Since appengine has its own logging mechanism - attached to the Context interface - I want to have a custom log package that abstracts this away.

But when I create a struct and call the Info method which delegates to seelog, I see this

[2013-09-05 23:50:33] [INFO] [101loops/log.(*Logger).Info] ...

instead of

[2013-09-05 23:50:33] [INFO] [101loops/module.start] ...

How can I make seelog log the correct location when being wrapped?

[goodsign]

Hi!

Could you please provide a small gist illustrating how you wrap seelog.

[stephanos]

Sure :)

https://gist.github.com/stephanos/6468975

[goodsign]

I see, so (*Logger).Info is actually the location where you call seelog.Info. And you want to be able to set custom stack depth where seelog gets 'current' function name. In your case you want to increase it by one.

It's possible to add this feature, let me think a bit about the implementation.

Thanks for suggestion!

[stephanos]

Exactly!

[goodsign]

Hi stephanos,

Please take a look at the feature implementation in commit c4b4bb1

You can even checkout the feature branch gs_issue_36 and test it in your environment to see if it fits well.

If we are on the same page and the implementation seems fine, then I'll proceed with merge and tagging.

[stephanos]

Just tried it out, works fine :)

[goodsign]

Great! I'll merge it soon!

[stephanos]

Great, this is why I love open source! 👍

[goodsign]

I'll be back soon and merge it into master + create a new tag. Time for a minor release :)

[goodsign]

Done! Everything merged to master + added a tag 'v2.4'.

Thanks for the issue!