New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Cilium CLI work with Cilium installed through helm with a non-default name #2274

Closed

giorio94 opened this issue Jan 30, 2024 · 6 comments · Fixed by #2430

Assignees

Labels

area/helm-mode good first issue kind/feature

Member

giorio94 commented Jan 30, 2024

Quite a few Cilium CLI commands fail with a release: not found error if Cilium got installed through helm with a non-default name.

For instance:

$ helm install -n kube-system cilium-break-cli cilium/cilium --version v1.14.5

$ cilium hubble enable
Error: Unable to enable Hubble: release: not found

$ cilium clustermesh enable --service-type LoadBalancer
Error: Unable to enable ClusterMesh: release: not found

This happens because we hardcode the default release name (for instance here). Instead, we should make it user-configurable, similarly to the namespace where Cilium is installed.

The text was updated successfully, but these errors were encountered:

giorio94 added kind/feature good first issue area/helm-mode labels

prashantrewar commented Jan 30, 2024

hey @giorio94, I would like to work on this issue. Could you please guide me on this?

Member Author

giorio94 commented Jan 30, 2024 •

edited

Sure, the idea is to make the helm release name configurable through a flag, similarly to the namespace case.

I'd suggest starting with introducing the new flag (which defaults to the current value), and then look for all the usages of defaults.HelmReleaseName and replace them with the propagated parameter.

Feel free to reach out if you have more questions.

giorio94 assigned prashantrewar

prashantrewar commented Jan 30, 2024

@giorio94, [namespace case] link is broken. Are you pointing this?

Member Author

giorio94 commented Jan 30, 2024

@giorio94, [namespace case] link is broken. Are you pointing this?

Yep, sorry. Should be fixed now.

Contributor

littlejo commented Mar 13, 2024

@prashantrewar Do you have news about this issue?

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add customizable Helm release name for Cilium

ca251ae

This update introduces a new parameter across several functions and actions to allow the user to specify a Helm release name for the Cilium installation. This enables multiple Cilium installations within the same cluster, or referencing installations installed via Helm directly. The default Helm release name remains "cilium" when no custom release name is provided.

Fixes: cilium#2274
Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

Contributor

matthewhembree commented Mar 19, 2024

@prashantrewar I wasn't sure if you were actively working on this or if you were busy with other things. I checked for a existing fork.

Apologies for being impatient, but I was interested in using the fix.

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add customizable Helm release name for Cilium

c91a10b

This update introduces a new parameter across several functions and actions to allow the user to specify a Helm release name for the Cilium installation. This enables referencing installations installed via Helm directly. The default Helm release name remains "cilium" when no custom release name is provided.

Fixes: cilium#2274
Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

matthewhembree mentioned this issue

feat: Make Cilium CLI work with Cilium installed through helm with a non-default name. #2430

Merged

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add customizable Helm release name for Cilium

f9aeb00

This update introduces a new parameter across several functions and actions to
allow the user to specify a Helm release name for the Cilium installation.
This enables referencing installations installed via Helm directly.
The default Helm release name remains "cilium" when no custom release name is provided.

Fixes: cilium#2274
Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add helmReleaseName to hubble disable parameters.

dd2c601

This is to allow `cilium hubble disable --helm-release-name foo` as missing
from a previous/complimentary commit.

Fixes: cilium#2274

Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add helmReleaseName to Hubble uninstall pre-phase of the core u…

ded05bb

…ninstall.

This is to allow `cilium uninstall --helm-release-name foo` to correctly uninstall Hubble
before uninstalling the core Cilium.

This includes a fix to specify the namespace.

Fixes: cilium#2274

Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add customizable Helm release name for Cilium

This update introduces a new parameter across several functions and actions to
allow the user to specify a Helm release name for the Cilium installation.
This enables referencing installations installed via Helm directly.
The default Helm release name remains "cilium" when no custom release name is provided.

Fixes: cilium#2274
Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add helmReleaseName to hubble disable parameters.

bd2a86a

This is to allow `cilium hubble disable --helm-release-name foo` as missing
from a previous/complimentary commit.

Fixes: cilium#2274

Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add helmReleaseName to Hubble uninstall pre-phase of the core u…

434b5cc

…ninstall.

This is to allow `cilium uninstall --helm-release-name foo` to correctly uninstall Hubble
before uninstalling the core Cilium.

This includes a fix to specify the namespace.

Fixes: cilium#2274

Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add customizable Helm release name for Cilium

43b8875

This update introduces a new parameter across several functions and actions to
allow the user to specify a Helm release name for the Cilium installation.
This enables referencing installations installed via Helm directly.
The default Helm release name remains "cilium" when no custom release name is provided.

Fixes: cilium#2274
Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add helmReleaseName to hubble disable parameters.

d16d56f

This is to allow `cilium hubble disable --helm-release-name foo` as missing
from a previous/complimentary commit.

Fixes: cilium#2274

Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add helmReleaseName to Hubble uninstall pre-phase of the core u…

c898797

…ninstall.

This is to allow `cilium uninstall --helm-release-name foo` to correctly uninstall Hubble
before uninstalling the core Cilium.

This includes a fix to specify the namespace.

Fixes: cilium#2274

Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add customizable Helm release name for Cilium

4ec5d70

This update introduces a new parameter across several functions and actions to
allow the user to specify a Helm release name for the Cilium installation.
This enables referencing installations installed via Helm directly.
The default Helm release name remains "cilium" when no custom release name is provided.

Fixes: cilium#2274
Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add helmReleaseName to hubble disable parameters.

0aead5c

This is to allow `cilium hubble disable --helm-release-name foo` as missing
from a previous/complimentary commit.

Fixes: cilium#2274

Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

matthewhembree added a commit to matthewhembree/cilium-cli that referenced this issue


          feat: Add helmReleaseName to Hubble uninstall pre-phase of the core u…

d4d8808

…ninstall.

This is to allow `cilium uninstall --helm-release-name foo` to correctly uninstall Hubble
before uninstalling the core Cilium.

This includes a fix to specify the namespace.

Fixes: cilium#2274

Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

tklauser closed this as completed in #2430

tklauser pushed a commit that referenced this issue


          feat: Add customizable Helm release name for Cilium

2f6245a

This update introduces a new parameter across several functions and actions to
allow the user to specify a Helm release name for the Cilium installation.
This enables referencing installations installed via Helm directly.
The default Helm release name remains "cilium" when no custom release name is provided.

Fixes: #2274
Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

tklauser pushed a commit that referenced this issue


          feat: Add helmReleaseName to hubble disable parameters.

fe56130

This is to allow `cilium hubble disable --helm-release-name foo` as missing
from a previous/complimentary commit.

Fixes: #2274

Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

tklauser pushed a commit that referenced this issue


          feat: Add helmReleaseName to Hubble uninstall pre-phase of the core u…

3a4b6b1

…ninstall.

This is to allow `cilium uninstall --helm-release-name foo` to correctly uninstall Hubble
before uninstalling the core Cilium.

This includes a fix to specify the namespace.

Fixes: #2274

Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment