Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI doesn't upgrade clustermesh-apiserver... #689

Closed
seimic opened this issue Jan 25, 2022 · 1 comment · Fixed by #993
Closed

CLI doesn't upgrade clustermesh-apiserver... #689

seimic opened this issue Jan 25, 2022 · 1 comment · Fixed by #993
Assignees
@squeed
Labels
good first issue Good for newcomers kind/bug Something isn't working kind/community-report This was reported by a user in the Cilium community, eg via Slack.

Comments

@seimic
Copy link

seimic commented Jan 25, 2022

Hi,

not sure if this is correct but I wonder a bit because of the results of an upgrade from 1.10.5 to 1.10.7.
The upgrade didn't touch the clustermesh-apiserver at all. Do I need to reinitialize the clustermesh
after upgrades?

Versions:

  • cilium-cli: v0.10.1 compiled with go1.17.6 on windows/amd64
  • cilium image (running): v1.10.7

Status (image versions) after upgrade from 1.10.5 to 1.10.7:

Image versions    cilium                   quay.io/cilium/cilium:v1.10.7: 6
                  cilium-operator          quay.io/cilium/operator-generic:v1.10.7: 1
                  clustermesh-apiserver    quay.io/coreos/etcd:v3.4.13: 1
                  clustermesh-apiserver    quay.io/cilium/clustermesh-apiserver:v1.10.5: 1

Clustermesh api-server is still version 1.10.5

Kind regards,
Michael
@seimic seimic added the kind/bug Something isn't working label Jan 25, 2022
@tklauser tklauser added kind/community-report This was reported by a user in the Cilium community, eg via Slack. needs/triage This issue requires triaging to establish the root cause. labels Jan 25, 2022
@tklauser
Copy link
Member

Thanks for the report @seimic. Indeed it looks like currently cilium upgrade will only upgrade the cilium DaemonSet and the cilium-operator Deployment. I think the command should also check whether clustermesh-apiserver and/or hubble-relay are installed and need to be upgrade.

Possibly also related: #190, #260

@tklauser tklauser added good first issue Good for newcomers and removed needs/triage This issue requires triaging to establish the root cause. labels Jan 25, 2022
@alexander-demicev alexander-demicev mentioned this issue Apr 22, 2022
Merged
squeed added a commit to squeed/cilium-cli that referenced this issue Jul 26, 2022
@squeed
upgrade: also bump clustermesh-apiserver
cd60c05 
We forgot to upgrade this particular DaemonSet if present.

Fixes: cilium#689
Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed mentioned this issue Jul 26, 2022
Merged
tklauser pushed a commit that referenced this issue Jul 28, 2022
@squeed @tklauser
upgrade: also bump clustermesh-apiserver
fdd4727 
We forgot to upgrade this particular DaemonSet if present.

Fixes: #689
Signed-off-by: Casey Callendrello <cdc@isovalent.com>
aditighag pushed a commit to aditighag/cilium-cli that referenced this issue Apr 21, 2023
@squeed @aditighag
upgrade: also bump clustermesh-apiserver
9719d8c 
We forgot to upgrade this particular DaemonSet if present.

Fixes: cilium#689
Signed-off-by: Casey Callendrello <cdc@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squeed squeed

Labels
good first issue Good for newcomers kind/bug Something isn't working kind/community-report This was reported by a user in the Cilium community, eg via Slack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade: also bump clustermesh-apiserver squeed/cilium-cli
3 participants
@tklauser @squeed @seimic