sysdump: exclude endpoint object files by default #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pchaigno @joamaki the follow-up PR to cilium/cilium#22370 |
pchaigno
approved these changes
Dec 2, 2022
christarazi
added
ready-to-merge
maintainer-s-little-helper
bot
removed
the
ready-to-merge
pchaigno
added
dont-merge/bad-bot
tklauser
requested changes
Dec 5, 2022
tklauser
removed
ready-to-merge
tbalthazar
commented
Dec 7, 2022
tbalthazar
force-pushed
the
tbalthazar/sysdump
branch
from
53df978
to
91f25d5
Compare
tbalthazar
force-pushed
the
tbalthazar/sysdump
branch
from
91f25d5
to
68f158c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tbalthazar
force-pushed
the
tbalthazar/sysdump
branch
from
68f158c
to
95c56ff
Compare
|
The staticcheck failures on the latest version of the branch look related: https://github.com/cilium/cilium-cli/actions/runs/3683477845 |
tbalthazar
force-pushed
the
tbalthazar/sysdump
branch
from
95c56ff
to
544f369
Compare
|
@tklauser lint issue should be fixed now |
tklauser
requested changes
Dec 13, 2022
There was a problem hiding this comment.
Thanks @tbalthazar! I think we're almost there, only two minor remarks left.
Set the `--exclude-object-files` flag that was added in cilium/cilium#22370 as a default flag when running sysdump. (only if cilium version >= 1.13.0). Signed-off-by: Thomas Balthazar <thomas@balthazar.info>
It will be used in other palces too. Signed-off-by: Thomas Balthazar <thomas@balthazar.info>
Signed-off-by: Thomas Balthazar <thomas@balthazar.info>
tbalthazar
force-pushed
the
tbalthazar/sysdump
branch
from
544f369
to
fea7555
Compare
|
@tklauser updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the
--exclude-object-filesflag that was added in cilium/cilium#22370 as a default flag when running sysdump.