connectivity: allow to restrict connectivity test pods using nodeSelector #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor
The connectivity test pods will be restricted to nodes matching labels
given in the --node-selector flag.
Usage:
$ kubectl get nodes
NAME STATUS ROLES AGE VERSION
kind-control-plane Ready control-plane 15m v1.25.3
kind-worker Ready <none> 15m v1.25.3
kind-worker2 Ready <none> 15m v1.25.3
kind-worker3 Ready <none> 15m v1.25.3
kind-worker4 Ready <none> 15m v1.25.3
$ kubectl label nodes kind-worker{2,3} connectivity.cilium.io/test=true
$ cilium connectivity test --node-selector connectivity.cilium.io/test=true
[...]
✅ All 32 tests (261 actions) successful, 2 tests skipped, 1 scenarios skipped.
$ kubectl get pods -n cilium-test -o wide
NAME READY STATUS RESTARTS AGE IP NODE NOMINATED NODE READINESS GATES
client-7858556799-xd52x 1/1 Running 0 5m56s 10.244.2.120 kind-worker3 <none> <none>
client2-646989676f-zgxxl 1/1 Running 0 5m56s 10.244.2.55 kind-worker3 <none> <none>
echo-other-node-79659b5c6-8dzfw 2/2 Running 0 5m55s 10.244.3.148 kind-worker2 <none> <none>
echo-same-node-69f7699d84-5bvxj 2/2 Running 0 5m56s 10.244.2.168 kind-worker3 <none> <none>
Fixes #1269
Signed-off-by: Tobias Klauser <tobias@cilium.io>
aanm
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connectivity test pods will be restricted to nodes matching labels given in the
--node-selectorflag.Usage:
Fixes #1269