Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Break generateManifests() into smaller functions #1453

Merged
merged 1 commit into from
Mar 15, 2023
Merged

refactor: Break generateManifests() into smaller functions #1453

merged 1 commit into from
Mar 15, 2023

Conversation

michi-covalent
Copy link
Contributor

Break generateManifests() into smaller functions without changing the logic to make it easier to reuse and unit test.

@michi-covalent michi-covalent temporarily deployed to ci March 15, 2023 04:31 — with GitHub Actions Inactive
@michi-covalent michi-covalent temporarily deployed to ci March 15, 2023 04:41 — with GitHub Actions Inactive
@michi-covalent michi-covalent temporarily deployed to ci March 15, 2023 05:01 — with GitHub Actions Inactive
@michi-covalent
refactor: Break generateManifests() into smaller functions
7d81388 
Break generateManifests() into smaller functions without changing the
logic to make it easier to reuse and unit test.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent temporarily deployed to ci March 15, 2023 05:25 — with GitHub Actions Inactive
@michi-covalent michi-covalent marked this pull request as ready for review March 15, 2023 05:40
@michi-covalent michi-covalent requested review from a team as code owners March 15, 2023 05:40
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 15, 2023
@tklauser tklauser merged commit 1a05658 into master Mar 15, 2023
@tklauser tklauser deleted the pr/michi/refactor branch March 15, 2023 09:16
@chenrui333 chenrui333 mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michi-covalent @rolinh @tklauser