Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: bump AKS BYOCNI workflow timeout #1593

Merged
merged 1 commit into from
May 8, 2023

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented May 8, 2023

The AKS BYOCNI workflow has been timing out quite often since being re-enabled. This is mainly due to the additional tests that were added since the workflow was disabled ~5 months ago. Follow commit 13ae2fa ("gha: Increase timeout for GKE") which increased timeouts for the GKE workflow in a similar fashion and bump the timeout by 15min.

See https://github.com/cilium/cilium-cli/actions/runs/4916363553/jobs/8780012198 for a recent timeout.

The AKS BYOCNI workflow has been timing out quite often since being
re-enabled. This is mainly due to the additional tests that were added
since the workflow was disabled ~5 months ago. Follow commit
13ae2fa ("gha: Increase timeout for GKE") which increased timeouts
for the GKE workflow in a similar fashion and bump the timeout by 15min.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser requested review from a team as code owners May 8, 2023 17:26
@tklauser tklauser requested a review from brlbil May 8, 2023 17:26
@tklauser tklauser temporarily deployed to ci May 8, 2023 17:26 — with GitHub Actions Inactive
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump it and ship it

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 8, 2023
@michi-covalent
Copy link
Contributor

who am i to question mlh. merging.

@michi-covalent michi-covalent merged commit 366a00d into main May 8, 2023
14 of 15 checks passed
@michi-covalent michi-covalent deleted the pr/tklauser/gh-aks-bump-timeout branch May 8, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants