Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connectivity: add full egress gateway test suite #1657

Merged
merged 3 commits into from May 31, 2023
Merged

connectivity: add full egress gateway test suite #1657

merged 3 commits into from May 31, 2023

Conversation

jibi
Copy link
Member

@jibi jibi commented May 25, 2023 •
edited

see individual commits

Towards: cilium/cilium#24151

@jibi jibi added the area/CI Continuous Integration testing issue or flake label May 25, 2023
@jibi jibi temporarily deployed to ci May 25, 2023 07:11 — with GitHub Actions Inactive
@jibi jibi temporarily deployed to ci May 25, 2023 07:32 — with GitHub Actions Inactive
@jibi jibi temporarily deployed to ci May 25, 2023 07:48 — with GitHub Actions Inactive
@jibi jibi temporarily deployed to ci May 25, 2023 07:58 — with GitHub Actions Inactive
@brb
Copy link
Member

brb commented May 25, 2023

I'm going to merge #1579 in a bit. There is a bit of overlap between your PR and the former.

@jibi jibi temporarily deployed to ci May 25, 2023 08:43 — with GitHub Actions Inactive
@jibi
Copy link
Member Author

jibi commented May 25, 2023

I'm going to merge #1579 in a bit. There is a bit of overlap between your PR and the former.

ack, still a few issues to solve here so all good 👍

@jibi jibi temporarily deployed to ci May 25, 2023 08:48 — with GitHub Actions Inactive
@jibi jibi temporarily deployed to ci May 25, 2023 09:14 — with GitHub Actions Inactive
@jibi jibi temporarily deployed to ci May 25, 2023 10:32 — with GitHub Actions Inactive
@jibi jibi temporarily deployed to ci May 26, 2023 10:05 — with GitHub Actions Inactive
@jibi jibi temporarily deployed to ci May 26, 2023 10:23 — with GitHub Actions Inactive
@jibi jibi temporarily deployed to ci May 26, 2023 10:35 — with GitHub Actions Inactive
@jibi jibi temporarily deployed to ci May 26, 2023 11:20 — with GitHub Actions Inactive
@jibi jibi temporarily deployed to ci May 26, 2023 11:56 — with GitHub Actions Inactive
@jibi jibi requested review from a team as code owners May 29, 2023 14:42
@jibi jibi requested a review from youngnick May 29, 2023 14:42
@jibi
Copy link
Member Author

jibi commented May 29, 2023

test run: https://github.com/cilium/cilium/actions/runs/5112893978/jobs/9191464799?pr=25719

brb
brb reviewed May 30, 2023
View reviewed changes
connectivity/check/context.go Outdated Show resolved Hide resolved
connectivity/check/test.go Outdated Show resolved Hide resolved
connectivity/manifests/egress-gateway-policy-excluded-cidrs.yaml Show resolved Hide resolved
connectivity/tests/egressgateway.go Outdated Show resolved Hide resolved
connectivity/tests/egressgateway.go Outdated Show resolved Hide resolved
@jibi jibi marked this pull request as draft May 30, 2023 09:39
@jibi jibi temporarily deployed to ci May 30, 2023 09:43 — with GitHub Actions Inactive
jibi added 2 commits May 30, 2023 12:06
@jibi
check: add NodeportService wrapper
d6c1998 
NodeportService wraps a Service object and can be used to expose said
Service through its nodeport with the Peer interface.

Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi
check: delete CiliumEgressGatewayPolicies after test run
3a145c4 
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi jibi temporarily deployed to ci May 30, 2023 10:08 — with GitHub Actions Inactive
@jibi jibi temporarily deployed to ci May 30, 2023 12:02 — with GitHub Actions Inactive
@jibi
Copy link
Member Author

jibi commented May 30, 2023

green run: https://github.com/cilium/cilium/actions/runs/5121292447/jobs/9208878978?pr=25719

@jibi jibi marked this pull request as ready for review May 30, 2023 12:49
brb
brb reviewed May 30, 2023
View reviewed changes
connectivity/suite.go Outdated Show resolved Hide resolved
@jibi
connectivity: add full egress gateway test suite
6f17c07 
This commit reimplement the Ginkgo test suite for egress gateway as a
connectivity test for the CLI.

The changes are split in 2 test suites:

* egress-gateway, which tests connectivity for pods matched by an egress
  gateway policy: pod to host, pod to service, pod to external IP, reply
  traffic for services and pods
* egress-gateway-excluded-cidrs, which tests the excludedCIDRs property
  and ensure traffic matching an excluded CIDR does not get masqueraded
  with the egress IP

Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi jibi temporarily deployed to ci May 30, 2023 13:02 — with GitHub Actions Inactive
brb
brb approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍕

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 31, 2023
@tklauser tklauser merged commit 4cce091 into main May 31, 2023
19 checks passed
@tklauser tklauser deleted the pr/jibi/egressgw-tests branch May 31, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@tklauser tklauser tklauser approved these changes

@youngnick youngnick youngnick approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jibi @brb @tklauser @youngnick